Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): add missing ssa configuration #2613

Merged
merged 1 commit into from
Oct 13, 2022
Merged

fix(image): add missing ssa configuration #2613

merged 1 commit into from
Oct 13, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Oct 13, 2022

Prepare

Description

Target issue

closes #2612

Implementation Details

  1. Synchronized templates from upstream.
  2. On fresh setup, SSA configuration are loaded from templates
  3. On existing setup, missing SSA configuration will be added into persistence

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu as a code owner October 13, 2022 12:01
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality labels Oct 13, 2022
@moabu moabu merged commit b70b8b2 into main Oct 13, 2022
@moabu moabu deleted the cn-ssa branch October 13, 2022 16:28
@mo-auto2 mo-auto2 mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(image): missing ssa configuration in the image
3 participants
@iromli @moabu @mo-auto