Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans auth server): well known uppercase grant_types response_mode #2706

Merged

Conversation

jmunozherbas
Copy link
Contributor

Prepare


Description

Requesting /.well-known/openid-configuration for the first time returns unexpected output for grant_types_supported and response_mode_supported, it returns uppercase values.

Target issue

#2183

closes #2183

Implementation Details

Loading of grant_types_supported and response_mode_supported
was modified to List<String> in endpoint /.well-known/openid-configuration
because JSONArray loading was causing the issue.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added the comp-jans-auth-server Component affected by issue or PR label Oct 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jmunozherbas jmunozherbas changed the title Fix jans auth server well known uppercase grant response mode fix(jans auth server): well known uppercase grant_types response_mode Oct 24, 2022
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Oct 24, 2022
@jmunozherbas jmunozherbas marked this pull request as ready for review October 24, 2022 07:12
@jmunozherbas
Copy link
Contributor Author

I have tested build successfully in local and jenkins, I dont know the reason why build here is not working.

@yuriyz yuriyz merged commit 39f613d into main Oct 24, 2022
@yuriyz yuriyz deleted the fix-jans-auth-server-well-known-uppercase-grant-response-mode branch October 24, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-auth-server): unexpected output of well-known/openid-configuration on first request
3 participants