Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): incorrect server response for missing agama resources #2924

Closed
moabu opened this issue Nov 8, 2022 · 7 comments · Fixed by #3028 or #3369
Closed

fix(jans-config-api): incorrect server response for missing agama resources #2924

moabu opened this issue Nov 8, 2022 · 7 comments · Fixed by #3028 or #3369
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@moabu
Copy link
Member

moabu commented Nov 8, 2022

When trying to fetch an agama flow that does not exist, instead of a 404 response, the server return 500. This was introduced with the latest deployment.

The request is run against /jans-config-api/api/v1/agama/QNAME where QNAME is the name of a flow that is not defined in the system.
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 8, 2022
@pujavs
Copy link
Contributor

pujavs commented Nov 8, 2022

@moabu, this is on jenkins build env
image

@moabu
Copy link
Member Author

moabu commented Nov 9, 2022

let me try again

@moabu moabu added this to the 1.0.5 milestone Nov 14, 2022
@moabu
Copy link
Member Author

moabu commented Nov 17, 2022

@pujavs the issue still seems to exist.This is with the latest on MySQL.
I'm still getting a 500 for the request.
202416094-3d36947c-e3d9-41a6-85d4-e71ac5acc18e

@pujavs pujavs mentioned this issue Nov 18, 2022
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Nov 18, 2022

handled Exception , fix via PR 3028

@moabu moabu reopened this Dec 20, 2022
@moabu
Copy link
Member Author

moabu commented Dec 20, 2022 •
edited
Loading

Now this is returning a 200 code instead of 404

@pujavs pujavs mentioned this issue Dec 20, 2022
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Dec 21, 2022

Fixed and tested on mysql env
Agama_404.zip

@moabu
Copy link
Member Author

moabu commented Dec 22, 2022

Tests and is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@pujavs @moabu @mo-auto