Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature to include custom-claims in user-info endpoint of admin-ui plugin #2969 #2970

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

duttarnab
Copy link
Contributor

The claims added to the session in the authentication script should be fetched in the user-info endpoint of the admin-ui plugin.

This is especially useful when we need to add some claims from the InBound custom script to jans user-info endpoint response.

  • create GitHub Inbound custom script. The script will also add GitHub username and access_token in the session.
  • create a GitHub Introspection script to add GitHub claims from the session to the Introspection response.
  • In the admin-ui plugin add the GitHub claims in the user-info response.

closes #2969

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Nov 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch out where the static files are being placed. They got moved from the linux setup to the docs folder.

@devrimyatar
Copy link
Contributor

@duttarnab Please move scripts to docs/script-catalog/introspection

@duttarnab
Copy link
Contributor Author

I have moved the script to docs/script-catalog/ directory.

@duttarnab duttarnab requested a review from moabu November 14, 2022 11:14
Copy link
Contributor

@devrimyatar devrimyatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script placeholders seems not correct. Please follow this guide #2999 (review)

@duttarnab
Copy link
Contributor Author

Script placeholders seems not correct. Please follow this guide #2999 (review)

Fixed

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz merged commit 0549879 into main Nov 16, 2022
@yuriyz yuriyz deleted the jans-config-api-issue-2969 branch November 16, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-config-api) : add feature to include custom-claims in user-info endpoint of admin-ui plugin
5 participants