Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fido2-client): conflict of log4j config #3636

Merged
merged 3 commits into from
Jan 18, 2023
Merged

fix(fido2-client): conflict of log4j config #3636

merged 3 commits into from
Jan 18, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jan 17, 2023

Prepare

Description

Excluded log4j file from client jar to fix the conflict

Target issue

closes #1603

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested a review from yurem as a code owner January 17, 2023 09:54
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 17, 2023
@pujavs pujavs mentioned this pull request Jan 17, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yurem yurem merged commit 77412d5 into main Jan 18, 2023
@yurem yurem deleted the jans-config-fixes branch January 18, 2023 13:18
@maduvena maduvena mentioned this pull request Jan 19, 2023
Closed
@mo-auto3 mo-auto3 mentioned this pull request Feb 22, 2023
Merged
@mo-auto mo-auto mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

Assignees
No one assigned
Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only log file YYYY_MM_DD.jetty.log is generated when fido2 client lib is added
3 participants
@pujavs @yurem @mo-auto