Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): custom script enhancement #3682

Closed
pujavs opened this issue Jan 24, 2023 · 1 comment · Fixed by #3786
Closed

feat(config-api): custom script enhancement #3682

pujavs opened this issue Jan 24, 2023 · 1 comment · Fixed by #3786
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request

Comments

@pujavs
Copy link
Contributor

pujavs commented Jan 24, 2023 •
edited
Loading

Two enhancements:

  • script : On creation of custom script if no script is passed then the default script is added. Enhancement to create default script only if explicitly indicated by additional param
  • locationType: Currently the default is ldap, this needs to be changed to db
@pujavs pujavs added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-config-api Component affected by issue or PR labels Jan 24, 2023
@pujavs pujavs self-assigned this Jan 24, 2023
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jan 24, 2023
This was referenced Feb 2, 2023
Merged
Merged
@pujavs
Copy link
Contributor Author

pujavs commented Feb 6, 2023

Implemented via PR 3786
Details:

  • script : On creation of custom script if no script is passed then the default script is added. Enhancement to create default script only if explicitly indicated by additional param
    New query param addScriptTemplate added - Boolean flag to indicate if script template is to be added. If CustomScript request object has script populated then script template will not be added.

  • locationType: Currently the default is ldap, this needs to be changed to db
    image

This was referenced Feb 6, 2023
Closed
Closed
@jgomer2001 jgomer2001 mentioned this issue Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config-api): script default script validation for location JanssenProject/jans
2 participants
@pujavs @mo-auto