Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jans-linux-setup create test client with all available scopes #3696

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented Jan 25, 2023

closes #3695

To create test-client, the following arguments can be provided to setup.py

  • -test-client-id ID of test client which has all available scopes (this argument triggers test client creation, other arguments are optional)
  • -test-client-secret Secret for test client (if not provided secret will be random characters)
  • -test-client-redirect-uri Redirect URI for test client (you can provide multiple uri's with comma, if not provided redirect uris will be same as config-api-client)
  • --test-client-trusted Make test client trusted (default is false)

@devrimyatar devrimyatar marked this pull request as draft January 25, 2023 17:21
@mo-auto mo-auto added comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Jan 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu
Copy link
Member

moabu commented Jan 25, 2023

closes #3695

To create test-client, the following arguments can be provided to setup.py

  • -test-client-id ID of test client which has all available scopes (this argument triggers test client creation, other arguments are optional)

  • -test-client-secret Secret for test client (if not provided secret will be random characters)

  • -test-client-redirect-uri Redirect URI for test client (you can provide multiple uri's with comma, if not provided redirect uris will be same as config-api-client)

  • --test-client-trusted Make test client trusted (default is false)

I think this meets the expectations as long as all the scopes available is assigned to this client.

One thing though , if not already we should enforce the structure of the client id so it meets the structure of the other clients in length.

Also , is the test client and it's respective secret added to the setup.properties.last ?

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@moabu moabu marked this pull request as ready for review January 25, 2023 18:48
@moabu moabu merged commit c2da52e into main Jan 25, 2023
@moabu moabu deleted the jans-linux-setup-create-client-with-all-scopes branch January 25, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for loading all neccessary scopes for all services in linux setup via flag
3 participants