Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-pycloudlib): re-running set_all method overwrites existing secrets/configs in AWS Secrets #3830

Closed
iromli opened this issue Feb 10, 2023 · 0 comments · Fixed by #3832
Assignees
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality

Comments

@iromli
Copy link
Contributor

iromli commented Feb 10, 2023

Describe the bug

Re-running configurator load command overwrites existing secrets/configs. Due to the behavior of string-based payload, there's no such concept of merge-with-existing data.

To Reproduce

Steps to reproduce the behavior:

  1. Deploy janssenproject/configurator with load command (choose aws adapter)
  2. Wait until configs and secrets pushed to AWS Secret Manager
  3. Deploy janssenproject/persistence; this will push other secrets/configs not created in step 1
  4. Repeat step 1 and 2
  5. Check secrets and configs (data created in step 3 are missing)

Expected behavior

Re-running janssenproject/configurator load command merges new data with existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
3 participants