fix(jans-pycloudlib): split google secrets when payload is larger than 65536 bytes #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-auto
added
comp-jans-pycloudlib
kind-bug
|
[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #3890 +/- ##
=======================================
Coverage ? 67.87%
=======================================
Files ? 30
Lines ? 2403
Branches ? 0
=======================================
Hits ? 1631
Misses ? 772
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Delete the secret. | ||
| self.client.delete_secret(request={"name": name}) | ||
| except NotFound: | ||
| logger.warning(f'Secret {self.google_secret_name} does not exist in the secret manager.') |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
moabu
approved these changes
Feb 20, 2023
This was referenced Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #3865
Implementation Details
Test and Document the changes