Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): agama deployment path param change and client authorization #4147

Merged
merged 11 commits into from
Mar 14, 2023
Merged

feat(config-api): agama deployment path param change and client authorization #4147

merged 11 commits into from
Mar 14, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Mar 14, 2023

Prepare

Description

  • 4048: Agama deployment path param changes
  • 3672: user consent mgmt

Target issue

closes #4048

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
fix(config-api): customObjectClass changes
93b5bec
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
d8908ec 
…ns-config-fix
@pujavs
fix(config-api): user custom attribute changes and agama param changes
5315017
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
3b05bbb 
…ns-config-fix
@pujavs
fix(config-api): user custom attribute changes and agama param changes
2e3e141
@pujavs
fix(config-api): user custom attribute changes and agama param changes
c5e458b
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a1e9b4b 
…ns-config-fix
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
e195ebc 
…ns-config-fix
@pujavs
feat(config-api): agama deployment path param change and client autho…
bad1ad6 
…rization
@pujavs
feat(config-api): agama deployment path param change and client autho…
c5f467e 
…rization
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Mar 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

[jans-config-api-parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability B 2 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

yuriyz
yuriyz reviewed Mar 14, 2023
View reviewed changes
...pi/plugins/user-mgt-plugin/src/main/java/io/jans/configapi/plugin/mgt/rest/UserResource.java
if (logger.isDebugEnabled()) {
logger.debug("User search param - limit:{}, pattern:{}, startIndex:{}, sortBy:{}, sortOrder:{}",
if (logger.isInfoEnabled()) {
logger.info("User search param - limit:{}, pattern:{}, startIndex:{}, sortBy:{}, sortOrder:{}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pujavs We are flipping logging level back on forth all the time. I guess we should decide what level do we use to log request/response and simply stick to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, there are issues cropping up for user mgmt for different persistence type and needed the logs to appear for these. Since debug is not the default log level and these logs were not appearing in logs when reported.

@yuriyz yuriyz merged commit 22323ce into main Mar 14, 2023
@yuriyz yuriyz deleted the jans-config-fix branch March 14, 2023 19:40
@pujavs pujavs mentioned this pull request Mar 14, 2023
Closed
@mo-auto3 mo-auto3 mentioned this pull request Mar 16, 2023
Merged
@mo-auto mo-auto mentioned this pull request Mar 16, 2023
Merged
@devrimyatar devrimyatar mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-config-api): agama deployment endpoints not conforming with the projects API style
3 participants
@pujavs @yuriyz @mo-auto