Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): jans-link plugin changes to use jans-link module #5626

Merged
merged 3 commits into from Jul 25, 2023
Merged

feat(config-api): jans-link plugin changes to use jans-link module #5626

merged 3 commits into from Jul 25, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Jul 25, 2023

Prepare

Description

Target issue

closes #5605

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested review from yuriyz and yurem as code owners July 25, 2023 10:31
@pujavs pujavs added the comp-jans-config-api Component affected by issue or PR label Jul 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
9.1% 9.1% Duplication

@yuriyz yuriyz merged commit f96ca52 into main Jul 25, 2023
4 checks passed
@yuriyz yuriyz deleted the jans-config-api-issues branch July 25, 2023 10:52
@pujavs pujavs mentioned this pull request Jul 25, 2023
Closed
@mo-auto mo-auto mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(config-api): reuse jans-link module classes
2 participants
@pujavs @yuriyz