Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove content-type in header from /retrieve GET request #6096 #6099

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

duttarnab
Copy link
Contributor

closes #6096

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Sep 21, 2023

private Optional<GenericResponse> handleLicenseApiNotAccessible(Response response) {
if (response.getStatus() == 404) {
log.error("{}", LICENSE_APIS_404);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duttarnab you don't need to involve formatter, it's as simple as log.error(LICENSE_APIS_404);

@yuriyz yuriyz merged commit a85d867 into main Sep 21, 2023
2 checks passed
@yuriyz yuriyz deleted the jans-config-api-issue-6096 branch September 21, 2023 18:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

[jans-config-api-parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
…6099)

* fix: remove content-type in header from /retrieve GET request #6096

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

* fix: remove content-type in header from /retrieve GET request #6096

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>

---------

Signed-off-by: Arnab Dutta <arnab.bdutta@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-config-api): remove content-type in header from /retrieve GET request
3 participants