Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycloak refactoring referred to Issue #5330 review #6157

Merged
merged 14 commits into from
Oct 11, 2023
Merged

Keycloak refactoring referred to Issue #5330 review #6157

merged 14 commits into from
Oct 11, 2023

Conversation

shekhar16
Copy link
Contributor

@mo-auto mo-auto added the comp-jans-config-api Component affected by issue or PR label Sep 28, 2023
yurem
yurem previously approved these changes Sep 29, 2023
View reviewed changes
@yurem yurem enabled auto-merge (squash) September 29, 2023 17:16
@shekhar16 shekhar16 changed the title Issues 5330 review Keycloak refactoring referred to Issue 5330 review Oct 2, 2023
@shekhar16 shekhar16 changed the title Keycloak refactoring referred to Issue 5330 review Keycloak refactoring referred to Issue #5330 review Oct 2, 2023
yurem
yurem previously approved these changes Oct 5, 2023
View reviewed changes
yuriyz
yuriyz requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version has to be in sync with main otherwise it will be out of sync with other projects in mono repo. Current version is 1.0.19-SNAPSHOT.

jans-keycloak-link/model/pom.xml Outdated Show resolved Hide resolved
jans-keycloak-link/pom.xml Outdated Show resolved Hide resolved
jans-keycloak-link/server/pom.xml Outdated Show resolved Hide resolved
jans-keycloak-link/server/weld-validation-report.html Outdated Show resolved Hide resolved
jans-keycloak-link/service/pom.xml Outdated Show resolved Hide resolved
yuriyz
yuriyz previously approved these changes Oct 7, 2023
View reviewed changes
yurem
yurem previously approved these changes Oct 10, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans link server parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 195 Code Smells

0.0% 0.0% Coverage
8.0% 8.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[jans-core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[casa-base] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[orm] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@moabu moabu disabled auto-merge October 11, 2023 05:56
@moabu moabu merged commit 7319120 into main Oct 11, 2023
13 of 15 checks passed
@moabu moabu deleted the issues_5330_review branch October 11, 2023 05:57
@moabu moabu mentioned this pull request Oct 11, 2023
Closed
@mo-auto mo-auto mentioned this pull request Oct 11, 2023
Merged
@mo-auto3 mo-auto3 mentioned this pull request Oct 11, 2023
Merged
@mo-auto mo-auto mentioned this pull request Oct 11, 2023
Merged
@mo-auto mo-auto mentioned this pull request Nov 8, 2023
Merged
@mo-auto mo-auto mentioned this pull request Dec 11, 2023
Merged
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
@shekhar16 @yurem @devrimyatar
feat: keycloak refactoring referred to Issue #5330 review (#6157)
9ce9164 
* feat(jans-keycloak-link): setup changes for keycloak migration review #5330

* chore: use only annotated beans

* chore: use only annotated beans

* chore: add fake beans producers

* chore: resolve dependency issues

* chore: reuse shared configuration in link and keycloack

* refactor(jans-keycloak-link): refactor the code to increase reusability

* refactor(jans-keycloak-link): refactor the code to increase reusability

* refactor(jans-keycloak-link): refactor the code to increase reusability

* Delete jans-config-api/docs/jans-config-api-swagger.yaml

* chore: update swagger docs files

* Revert "Delete jans-config-api/docs/jans-config-api-swagger.yaml"

This reverts commit e424397.

* refactor(jans-keycloak-link): refactor the pom version

---------

Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem yurem approved these changes

@pujavs pujavs Awaiting requested review from pujavs pujavs is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shekhar16 @yuriyz @yurem @moabu @mo-auto