Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (TUI): JWT Response for OAuth Token Introspection #6382

Closed
nynymike opened this issue Oct 24, 2023 · 6 comments · Fixed by #6566 or #6574
Closed

feat (TUI): JWT Response for OAuth Token Introspection #6382

nynymike opened this issue Oct 24, 2023 · 6 comments · Fixed by #6566 or #6574
Assignees
Labels
enhancement kind-feature Issue or PR is a new feature request priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system
Milestone

Comments

@nynymike
Copy link
Contributor

nynymike commented Oct 24, 2023

This was implemented in #3658, but I'm not sure it was exposed in the TUI. For example, it could be in the Encryption/Signing section, or it could also be in the Tokens section.

I dont' see any way to configure the signing and encryption for the introspection endpoint.
image

For example here is a screenshot of Forgerock:
image

@nynymike nynymike added priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system enhancement labels Oct 24, 2023
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Oct 24, 2023
@yuriyz
Copy link
Contributor

yuriyz commented Oct 24, 2023

It is already done. See #3658 (comment)
Closing as implemented.

@yuriyz yuriyz closed this as completed Oct 24, 2023
@yuriyz yuriyz assigned yuriyz and unassigned moabu Oct 24, 2023
@yuriyz yuriyz added this to the 1.0.20 milestone Oct 24, 2023
@nynymike
Copy link
Contributor Author

I changed this to track a feature request for the TUI.

@nynymike nynymike reopened this Oct 24, 2023
@nynymike nynymike assigned devrimyatar and yuriyz and unassigned yuriyz Oct 24, 2023
@nynymike nynymike changed the title feat (Auth Server): JWT Response for OAuth Token Introspection feat (TUI): JWT Response for OAuth Token Introspection Oct 24, 2023
@yuriyz
Copy link
Contributor

yuriyz commented Oct 26, 2023

@devrimyatar please hold on. Not sure how it got missed but AS picks up signing algorithm from defaultSignatureAlgorithm configuration property while spec clearly saying about client specific (not global):

  • introspection_signed_response_alg
  • introspection_encrypted_response_alg
  • introspection_encrypted_response_enc

Also supported algs has to be introduced by discovery endpoint.

Re-opened - #3658

@pujavs
Copy link
Contributor

pujavs commented Nov 15, 2023

@yuriyz, config-api does not expose /introspection or /register jans-auth endpoint.

Please confirm which attributes from this schema definition or if any change required in config-api for this issue.

@yuriyz
Copy link
Contributor

yuriyz commented Nov 15, 2023

@pujavs it's about ClientAttributes, is it autogenerated as well ?
Config-api does not have all attributes defined in AS ClientAttributes
https://github.com/JanssenProject/jans/blob/main/jans-config-api/docs/jans-config-api-swagger.yaml#L9003C5-L9003C21

For example these are missed in swagger:

    @JsonProperty("introspectionSignedResponseAlg")
    private String introspectionSignedResponseAlg;

    @JsonProperty("introspectionEncryptedResponseAlg")
    private String introspectionEncryptedResponseAlg;

    @JsonProperty("introspectionEncryptedResponseEnc")
    private String introspectionEncryptedResponseEnc;

@pujavs
Copy link
Contributor

pujavs commented Nov 16, 2023

Regenerated openapi spec to reflect new fields and pushed changes via PR 6566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement kind-feature Issue or PR is a new feature request priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system
Projects
None yet
6 participants