Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-tui): the tag field mandatory in request body when saving config-api permission in admin ui configuration. #6555

Closed
duttarnab opened this issue Nov 13, 2023 · 2 comments · Fixed by #6556
Closed

feat(jans-tui): the tag field mandatory in request body when saving config-api permission in admin ui configuration. #6555

duttarnab opened this issue Nov 13, 2023 · 2 comments · Fixed by #6556
Assignees
@devrimyatar
Labels
comp-jans-tui kind-feature Issue or PR is a new feature request
Milestone
1.0.21

Comments

@duttarnab
Copy link
Contributor

When saving/modifying admin ui permission the tag field is mandatory.

Sample POST and PUT request

curl -X PUT -k -H 'Authorization: Bearer <token-here...>' -H 'Content-Type: application/json' -i https://jv18creator-golden-crane/jans-config-api/admin-ui/adminUIPermissions --data '{"tag":"saml-scope","permission":"https://jans.io/oauth/config/saml-scope.readonly"}'

curl -X POST -k -H 'Authorization: Bearer <token-here...>' -H 'Content-Type: application/json' -i https://jv18creator-golden-crane/jans-config-api/admin-ui/adminUIPermissions --data '{"tag":"demo","permission":"https://jans.io/oauth/config/demo.readonly"}'
@duttarnab duttarnab added kind-bug Issue or PR is a bug in existing functionality comp-jans-tui labels Nov 13, 2023
@duttarnab duttarnab added kind-feature Issue or PR is a new feature request and removed kind-bug Issue or PR is a bug in existing functionality labels Nov 13, 2023
@devrimyatar
Copy link
Contributor

@duttarnab Should we post tag for only admin-ui endpoints? Or for all endpints of config-api?

@duttarnab
Copy link
Contributor Author

only for https://jv18creator-golden-crane/jans-config-api/admin-ui/adminUIPermissions endpoint.

@devrimyatar devrimyatar mentioned this issue Nov 13, 2023
Merged
@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
comp-jans-tui kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.21
Development

Successfully merging a pull request may close this issue.

feat(jans-linux-tui): tag field for endpoint adminUIPermissions JanssenProject/jans
3 participants
@devrimyatar @duttarnab @moabu