Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-tui): Post Auth and Spontaneous Scope script type are not appearing in Script Type list via Jans TUI #6615

Closed
mmrraju opened this issue Nov 22, 2023 · 2 comments · Fixed by #6617
Assignees
Labels
kind-bug Issue or PR is a bug in existing functionality
Milestone

Comments

@mmrraju
Copy link
Contributor

mmrraju commented Nov 22, 2023

Describe the bug
Post Auth and Spontaneous Scope script type are not appearing in Script Type list via Jans TUI.
According to docs. All Script type should be appeared in Script Type list via Jans TUI.

To Reproduce
Steps to reproduce the behavior using Jans TUI:

  1. Go to Scripts> Add scripts> Script Type

Expected behavior
All script Type should appear in the drop-down list.

Version [v1.0.21.nightly]

@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Nov 22, 2023
@devrimyatar
Copy link
Contributor

@mmrraju It is not related to TUI. When you enter scripts page, TUI queries endpoint /api/v1/config/scripts/types of config-api for script types:

https://github.com/JanssenProject/jans/blob/main/jans-cli-tui/cli_tui/plugins/060_scripts/main.py#L51-L64

And then uses it to populate dropdown list:

https://github.com/JanssenProject/jans/blob/main/jans-cli-tui/cli_tui/plugins/060_scripts/edit_script_dialog.py#L126-L130

@pujavs Please update config-api so that it returns all script types

@pujavs
Copy link
Contributor

pujavs commented Nov 23, 2023

Fixed and raised PR 6617

@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants