Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api-saml-plugin): making clientId optional field #6616

Closed
pujavs opened this issue Nov 23, 2023 · 1 comment
Closed

fix(config-api-saml-plugin): making clientId optional field #6616

pujavs opened this issue Nov 23, 2023 · 1 comment
Assignees
@pujavs
Labels
kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.21

Comments

@pujavs
Copy link
Contributor

pujavs commented Nov 23, 2023 •
edited
Loading

Issue: KC doesn't really distinguish between an OIDC client and a SAML Client. And hence for a SAML Client , the Client ID is a required field and corresponds to the url of the SP.

Solution: However from jans perspective clientId is not required for SAML and hence marking it optional for config-api-saml-plugin as this plugin only persists data in DB.

Note: For KC client/SAML Trust relationship creation the jans KC module will take care of clientId creation.
@pujavs pujavs self-assigned this Nov 23, 2023
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Nov 23, 2023
@pujavs pujavs mentioned this issue Nov 23, 2023
Merged
5 tasks
@pujavs
Copy link
Contributor Author

pujavs commented Nov 23, 2023

Fixed and raised PR 6617

@pujavs pujavs closed this as completed Nov 24, 2023
@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.21
Development

No branches or pull requests
3 participants
@pujavs @moabu @mo-auto