Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): syntax error in jans-config-api swagger specs #6622

Closed
duttarnab opened this issue Nov 24, 2023 · 4 comments · Fixed by #6780
Closed

fix(jans-config-api): syntax error in jans-config-api swagger specs #6622

duttarnab opened this issue Nov 24, 2023 · 4 comments · Fixed by #6780
Assignees
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone

Comments

@duttarnab
Copy link
Contributor

Getting syntax error in https://editor.swagger.io/ on opening following config-api spec.

@duttarnab duttarnab added kind-bug Issue or PR is a bug in existing functionality comp-jans-config-api Component affected by issue or PR labels Nov 24, 2023
@duttarnab duttarnab changed the title fix(jans-config-api): syntax error in jans-config-api fix(jans-config-api): syntax error in jans-config-api swagger specs Nov 24, 2023
@ossdhaval
Copy link
Contributor

As @pujavs mentioned, version tag is required.

@moabu Can we expand the scope of release placeholder replacement script to cover yaml files as well? If we can, then we can put version in OpenApi SPEC as vreplace-janssen-version.

@moabu
Copy link
Member

moabu commented Nov 27, 2023

Yes we can @ossdhaval . We have to understand that the head here main will always contain the placeholder.

@ossdhaval ossdhaval assigned ossdhaval and unassigned pujavs Nov 27, 2023
@ossdhaval
Copy link
Contributor

Ok, I'll work on this. cc: @pujavs .

@ossdhaval
Copy link
Contributor

@pujavs we won't need to add complex version replacement mechanism there. We can add version="".

We don't really need version tag as the versioning info is captured in the spec path and URL as well.

image

@moabu moabu added this to the 1.0.21 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants