Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change jetty favicon with jans favicon #7618

Closed
moabu opened this issue Feb 1, 2024 · 3 comments
Closed

fix: change jetty favicon with jans favicon #7618

moabu opened this issue Feb 1, 2024 · 3 comments
Assignees
Labels
kind-bug Issue or PR is a bug in existing functionality

Comments

@moabu
Copy link
Member

moabu commented Feb 1, 2024

load janssen favicon in place of jettys'

You can see this in your browser settings:

chrome://settings/content/all?searchSubpage=gluu.org&search=cookies

@moabu moabu self-assigned this Feb 1, 2024
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Feb 1, 2024
@iromli iromli self-assigned this Feb 12, 2024
@syntrydy
Copy link
Contributor

@mustafa Below are the steps to override the default jetty favicon.

  • From JETTY_HOME move into lib folder
  • 'mkdir -p org/eclipse/jetty'
  • Move the official Jans favicon into the folder created above(org/eclipse/jetty)
  • Then run 'jar -uf jetty-server-VERSION.jar org/eclipse/jetty/favicon.ico' where VERSION is the current jetty version.
    eg. jar -uf jetty-server-11.0.15.jar org/eclipse/jetty/favicon.ico

I think we need this apply during the setup process.

1 similar comment
@syntrydy
Copy link
Contributor

@mustafa Below are the steps to override the default jetty favicon.

  • From JETTY_HOME move into lib folder
  • 'mkdir -p org/eclipse/jetty'
  • Move the official Jans favicon into the folder created above(org/eclipse/jetty)
  • Then run 'jar -uf jetty-server-VERSION.jar org/eclipse/jetty/favicon.ico' where VERSION is the current jetty version.
    eg. jar -uf jetty-server-11.0.15.jar org/eclipse/jetty/favicon.ico

I think we need this apply during the setup process.

@iromli
Copy link
Contributor

iromli commented May 31, 2024

This has been implemented in #8334 and #8361

@iromli iromli closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants