Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validity length (in days) for certs #981

Merged
merged 2 commits into from
Mar 7, 2022
Merged

feat: add validity length (in days) for certs #981

merged 2 commits into from
Mar 7, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Mar 6, 2022 •
edited
Loading

Description

Document the changes

  • Added new option named valid-to (example: certmanager patch web --opts valid-to:397) where value is an integer greater than equal 1 (if value is below 1 or non-integer, fallback to default value 365); the value represents number of days.
  • Affected services: web, ldap, client-api
  • Refer to README.md for new option

@iromli iromli added comp-docker-jans-certmanager kind-feature Issue or PR is a new feature request labels Mar 6, 2022
@iromli iromli requested a review from moabu as a code owner March 6, 2022 21:09
@iromli iromli linked an issue Mar 6, 2022 that may be closed by this pull request
Support supplying the validity length of coupled certificates #684
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2022

[jans-pycloudlib] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mo-auto
chore(jans-pycloudlib): updated build (#982)
f92f0ce 
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu moabu merged commit abc89dc into main Mar 7, 2022
@moabu moabu deleted the cn-cert-validity branch March 7, 2022 06:53
@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[jans-client-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

This was referenced Mar 14, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-certmanager kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support supplying the validity length of coupled certificates
3 participants
@iromli @moabu @mo-auto