Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locust test #257

Merged
merged 28 commits into from May 19, 2022
Merged

Locust test #257

merged 28 commits into from May 19, 2022

Conversation

Gorgeous-Patrick
Copy link
Contributor

Finally the locust test program is viable.
A minor issue is that the system reports a failure when it is trying to register a user that exists. I think that maybe the locust system can ignore that error.
Another problem when running the JPrime is that the system still cannot load the external services.

@ypkang ypkang mentioned this pull request May 7, 2022
@Gorgeous-Patrick
Copy link
Contributor Author

I have added a docker compose file It seems that it is working rn

@ypkang ypkang self-assigned this May 11, 2022
@ypkang
Copy link
Contributor

ypkang commented May 11, 2022

Great. I will test this out today and merge if no problem occurs.

@ypkang
Copy link
Contributor

ypkang commented May 15, 2022

Met with @Gorgeous-Patrick to discuss this PR and here are the remaining ToDos. Just documenting them here.

  • Separating preparation steps and actual load test API calls. Only call the preparation steps once per load testing run.
  • Prep steps: create users, register sentinels, load actions
  • Load test steps: actual walker runs.

@ypkang
Copy link
Contributor

ypkang commented May 15, 2022

@Gorgeous-Patrick I have switched this PR to be a WIP draft PR since you are working on it. Switch to ready for review when you are done and I will review.

@ypkang ypkang marked this pull request as draft May 15, 2022 19:59
@Gorgeous-Patrick Gorgeous-Patrick marked this pull request as ready for review May 17, 2022 03:11
@Gorgeous-Patrick
Copy link
Contributor Author

I believe that the locust test is ready for review @ypkang

@ypkang ypkang self-requested a review May 19, 2022 01:05
Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this and made some improvements and tweaks along the way. This is overall pretty good.

@ypkang ypkang merged commit a5e02f4 into Jaseci-Labs:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants