Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOCIALAUTH]: Update and Refactor #710

Merged
merged 1 commit into from Jan 5, 2023

Conversation

amadolid
Copy link
Collaborator

Describe your changes

  • Add support on manual set on callback_url from FE
  • Added Facebook sample integration
  • Some refactor

Link to related issue

N/A

Does this introduce new feature or change existing feature of Jaseci? If so, please add tests.

No

Will this impact Jaseci users? If so, please write a paragraph describing the impact.

No

Anything in this PR should the Jaseci developer/contributor community pay particular attention to? If so, please describe.

Social Login

CHANGES:
 - Add support on manual set on callback_url from FE
 - Added Facebook sample integration
 - Some refactor
Copy link
Contributor

@marsninja marsninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @amadolid

@marsninja marsninja merged commit 3d4a10a into Jaseci-Labs:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants