Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worker count exhaustion bug #17

Closed
wants to merge 1 commit into from
Closed

Fix worker count exhaustion bug #17

wants to merge 1 commit into from

Conversation

AshishMahendra
Copy link
Collaborator

@AshishMahendra AshishMahendra commented Mar 4, 2024 •
edited by chandralegend
Loading

Fix Worker Count exhaustion bug

Fix worker count exhaustion bug

Reference Issue

#9

Description

  • This PR resolves an issue within the human evaluation system where workers were allowed to proceed through the login process, including captcha verification and worker ID submission, even after reaching the maximum allowed worker count. The implemented fix moves the worker count check to the beginning of the login process.

Changes

  • The worker count is now checked immediately upon login attempt before presenting the captcha and worker ID input fields.

Additional context

@AshishMahendra AshishMahendra linked an issue Mar 4, 2024 that may be closed by this pull request
Worker count exhaustion [Bug] #9
Open
@AshishMahendra AshishMahendra self-assigned this Mar 4, 2024
@AshishMahendra AshishMahendra added the bug Something isn't working label Mar 4, 2024
@chandralegend
Copy link
Collaborator

@AshishMahendra There is another concern we have to address here. Resetting the Count through the settings. That should do the following

  1. Backup the Current Things
  2. Find the Completed ones and remove from the distribution
  3. Resetting the worker count

chandralegend
chandralegend requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@chandralegend chandralegend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more things to consider in this PR

@chandralegend chandralegend marked this pull request as draft March 5, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandralegend chandralegend chandralegend requested changes

Assignees

@AshishMahendra AshishMahendra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker count exhaustion [Bug]
2 participants
@AshishMahendra @chandralegend