-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users can un-favorite items from favorites portlet #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from representing folder type as one of four integer values to representing folder type as exactly the String type attribute on the underlying folder XML element. This makes novel type values available through the Java API.
Switch to identifying the folder containing favorites by its type attribute rather than by its name. Pulls favorites functionality into a Helper class. Changes nomenclature to “collections” of favorites rather than “tabs”.
Fixes favorites view mode to display all favorited collections (tabs).
…ration Initialize parameters Hashtable at declaration rather than inline in constructors.
Reflect more of channel description state in toString(), making logging of channel descriptions more useful.
Without the fix to `UserLayoutNodeDescription`, the assertions that DLM attributes copied fail in included unit test.
…utes. Switch UserLayoutChannelDescription copy constructor to invoke superclass copy constructor so as to copy superclass-managed attributes. Exercised by included unit test. Test of copy of Node attributes fails without this fix.
Reflect in the `edit.jsp` whether items can be un-favorited. Detect in controller when attempts to un-favorite will fail for lack of permissions.
timlevett
added a commit
that referenced
this pull request
Jan 16, 2014
Users can un-favorite items from favorites portlet
apetro
pushed a commit
that referenced
this pull request
Jul 8, 2015
MUMUP-1119 : Add in fname parameter so we can add portlets via fname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add un-favorite functionality to Favorites portlet via EDIT portlet mode.
Note that this is a pull request for adding un-favoriting functionality to the favorites feature branch, not a pull request against trunk.
Known shortcomings, deferred work, and technical debt
Big picture design
type="favorites"
ActionRequest
s generated via<portlet:ActionURL/>
s (not AJAX)Edit UI features
errorMessage
andsuccessMessage
by the edit mode RenderRequest handler).Backing code
UserLayoutFolderDescription
now reflects the underlyingfolder
type
attribute rather than being constrained to four hard-coded possible values. This is howtype="favorites"
is visible to the Favorites portlet.UserLayout*Description
classes now do more of the copying you probably thought they already did. :) In particular, they now copy DLM attributes. This is demonstrated by unit tests.UserLayout*Description
classes now have richertoString()
s to facilitate detailed logging attrace
level in the Edit controller.