UP-3912 Admin UI Updates

[doodelicious]

https://issues.jasig.org/browse/UP-3912

• Added icons to menu items, made them to look like buttons (so they stand out);
• Updated single-entity-select to look like multi-entity-select (without changing functionality, can still only select one);
• In 'Manage Portlets', updated table nav to Bootstrap styles; added icons to table links;
• Permissions manager looks more like Universailty but Bootstrap-y

[apetro]

Lovely. Did not locally test, but on static review looks positive. 👍 for merge.

Noting some .less files disappearing in this changeset, which seems entirely fine for master; but I suggest not making that kind of change in 4.1-patches as too much change vis a vis any local customizations to that less.

[drewwills]

Looks like a merge conflict snuck in.

[drewwills]

@apetro -- FWIW, I think uPortal maintainers could be free to add or remove .less files in the respondr/common/less/ directory because the (documented/encouraged) process of skinning the portal does not involve making local changes to those files. There's nothing in those files you can't override in the mySkin/less/ directory. The exception to this statement would be the common/common.less file itself. That shouldn't disappear because local skins will be importing it directly.

[doodelicious]

What I discovered is the file I removed was not called in the common.less file - at all. I think that when the conversion happened, this file was left out and styles were added other places. This was simply a clean-up on my part. You can keep it there, just be aware that code exists in that file that is not compiled anywhere.

On Nov 11, 2014, at 11:06 AM, Drew Wills notifications@github.com wrote:

@apetro https://github.com/apetro -- FWIW, I think uPortal maintainers could be free to add or remove .less files in the respondr/common/less/ directory because the (documented/encouraged) process of skinning the portal does not involve making local changes to those files. There's nothing in those files you can't override in the mySkin/less/ directory. The exception to this statement would be the common/common.less file itself. That shouldn't disappear because local skins will be importing it directly.

—
Reply to this email directly or view it on GitHub #445 (comment).

[jhelmer-unicon]

Are these rules so broad that they could impact styling from other portlets? Doesn't seem good that when this view is visible buttons everywhere on the page may get different styling. Wonder if they shouldn't be more like:

.view-chooseportlet .form-group {} and .view-chooseportlet .buttons {}

[doodelicious]

This issue is corrected in this pull request: doodelicious@22668cd

[drewwills]

Merged out-of-band due to cleanup of conflicts.