Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA: Update link to individual contributor license agreement #881

Merged
merged 1 commit into from May 11, 2017

Conversation

ChristianMurphy
Copy link
Member

Checklist
Description of change

ICLA pdf has been removed, the online submission form is now recommended.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 22.89% when pulling 7cc7239 on ChristianMurphy:NOJIRA-icla-link into 554fae3 on Jasig:master.

Copy link
Member

@apetro apetro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised the PDF was removed. As I understand it that was not intended and I'll follow up on that.

Nonetheless, the not-PDF-specific URL path is superior in every way and it's an improvement to update CONTRIBUTING.md in this way.

@vertein
Copy link
Contributor

vertein commented May 10, 2017

I just printed off a copy, and I also looked for the pdf. I just printed off a copy of the web form. It seemed weird, but maybe because I expected the pdf.

@ChristianMurphy ChristianMurphy added this to the 5.0.0 milestone May 10, 2017
@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented May 10, 2017

@vertein You're right, the ICLA page looks off in print mode. It could use a print stylesheet to improve the appearance.

@bjagg bjagg self-requested a review May 11, 2017 22:50
Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@bjagg bjagg merged commit 87c9755 into uPortal-Project:master May 11, 2017
@ChristianMurphy ChristianMurphy deleted the NOJIRA-icla-link branch May 11, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants