Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min operation #4

Merged
merged 1 commit into from
May 10, 2017
Merged

Add min operation #4

merged 1 commit into from
May 10, 2017

Conversation

sea1jxr
Copy link
Contributor

@sea1jxr sea1jxr commented May 10, 2017

Just a copy of max with the greater than switched to less than.

One interesting difference the tests pointed out is that max kind of works with nulls

expext(genSequence([null, 1, null, 2]).max()).to.equal(2)

where the min doesn't because null is compared a lot like zero.

expext(genSequence([null, 1, null, 2]).min()).to.be.null

I think that is fine because we were saying that users should filter out items they don't want included in the operation.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 99.776% when pulling 0ac0dad on sea1jxr:min into 438a3ae on Jason3S:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 99.776% when pulling 0ac0dad on sea1jxr:min into 438a3ae on Jason3S:master.

@Jason3S Jason3S merged commit e7de93a into streetsidesoftware:master May 10, 2017
@Jason3S
Copy link
Collaborator

Jason3S commented May 10, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants