fix: Add option to subscribe immediately to an observable. #109

Jason3S · 2021-07-18T17:34:31Z

Add lazy option to Options.

Jason3S · 2021-07-18T18:02:06Z

src/rxToStream.ts

@@ -101,4 +89,40 @@ class ReadableObservableStream<T> extends stream.Readable {
            }
        }
    }
+
+    private subscribe() {
+        if (this._subscription) return;


@vibl

The check is in the subscribe.

Oops, sorry :-)

I put it here to avoid double subscription.

The if could also be in the _read() function for a tiny-tiny bit more speed, but I thought it was better to have the subscription logic in one place.

Ok, although that makes the name of the method somewhat misleading (which is why I didn't think of looking into it).

Jason3S added 2 commits July 18, 2021 19:31

ci: Update packages

48c7ad3

fix: fix #106

620081b

Add lazy option to Options.

Jason3S merged commit 81fcec5 into main Jul 18, 2021

Jason3S deleted the dev branch July 18, 2021 17:36

Jason3S commented Jul 18, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add option to subscribe immediately to an observable. #109

fix: Add option to subscribe immediately to an observable. #109

Jason3S commented Jul 18, 2021

Jason3S Jul 18, 2021

vibl Jul 18, 2021

Jason3S Jul 18, 2021 •

edited

vibl Jul 18, 2021

fix: Add option to subscribe immediately to an observable. #109

fix: Add option to subscribe immediately to an observable. #109

Conversation

Jason3S commented Jul 18, 2021

Jason3S Jul 18, 2021

Choose a reason for hiding this comment

vibl Jul 18, 2021

Choose a reason for hiding this comment

Jason3S Jul 18, 2021 • edited

Choose a reason for hiding this comment

vibl Jul 18, 2021

Choose a reason for hiding this comment

Jason3S Jul 18, 2021 •

edited