Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git to get code on webhook request #360

Closed
jesus2099 opened this issue May 13, 2015 · 3 comments
Closed

Use git to get code on webhook request #360

jesus2099 opened this issue May 13, 2015 · 3 comments

Comments

@jesus2099
Copy link
Contributor

In the same field as #318, I have noticed something strange (but it’s not very serious problem).

I pushed a newer version of a script (2015.5.13.1555) then a few minutes later, before Greasy Fork had updated, I pushed another version (2015.5.13.1611).

When Greasy Fork updated on github web hook, it did take the latest script version (1611) code, but its latest commit message was not concatenated in the script changelog :

CHG. added another english article (an) to the loose title ignore list

@JasonBarnabe
Copy link
Collaborator

Greasy Fork will get the commit messages from the webhook, wait a bit for GH's caching to expire, then get the file contents. If you push again before it grabs the file contents, then it's possible for what happened to you to happen.

Really, I think we should update GF to get the library with git rather than over a (caching) HTTP server. That would prevent this problem and makes things better all-around.

@JasonBarnabe JasonBarnabe changed the title A commit message was not concatenated in the script changelog (github webhook) Use git to get code on webhook request May 17, 2015
@JasonBarnabe
Copy link
Collaborator

git archive looks like the best way to accomplish that without pulling the whole repo.

@JasonBarnabe
Copy link
Collaborator

b602258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants