Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@grant requirements? #50

Closed
JasonBarnabe opened this issue Mar 6, 2014 · 7 comments
Closed

@grant requirements? #50

JasonBarnabe opened this issue Mar 6, 2014 · 7 comments

Comments

@JasonBarnabe
Copy link
Collaborator

http://wiki.greasespot.net/@grant

Is it useful to make scripts declare @grant? Perhaps detect what they need and add the meta ourselves, which would help against obfuscation of malicious code?

@cletusc
Copy link

cletusc commented Mar 7, 2014

From my understanding, @grant isn't required at my moment, but GM does notify when a script is missing them. I would, if possible, detect all of the standard @grant things and offer to add them if they are missing, or suggest what to do. In the case where none are detected (or needed), offer to add @grant none.

@grant isn't required now, but it would be nice if in the future it would be--why not have a host lead the way and get this stuff standardized as much as possible? As with the other stuff, don't disallow a script, but warn with a "save anyway" option (edit: and if GM makes it required one day, it should be changed here too).

@grant
Copy link

grant commented Mar 7, 2014

🐵 👍

@cletusc
Copy link

cletusc commented Mar 7, 2014

For reference, here is how GM sniffs out the @grants.

@supahgreg
Copy link

FWIW, Scriptish does require @grant

@jerone
Copy link
Contributor

jerone commented Apr 25, 2014

FWIW, Scriptish does require @grant

Scriptish doesn't require @grant. This blog post from Juli 2013 says it is required, but the code says not.
Here's how Scriptish sniffs out the @grant's

@cletusc
Copy link

cletusc commented Apr 25, 2014

@JasonBarnabe
Copy link
Collaborator Author

What Greasemonkey doing is reasonable now, and I don't see any APIs that jump out at me at being so out of line that I'd want to block scripts that used them, so I don't see the need to do anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants