Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Pin icons #79

Open
payt1400 opened this issue Mar 20, 2017 · 10 comments
Open

Change Pin icons #79

payt1400 opened this issue Mar 20, 2017 · 10 comments

Comments

@payt1400
Copy link

Is it possible to change google map pin icon if so how?

@realitix
Copy link
Contributor

realitix commented Jul 4, 2017

Hello @payt1400.
Currently, you can't change the icon, only the default icon is used.
This is a feature request.

Can you rename the issue:

[Feature] Allow to customize pin icon in map view

Thanks

@maks
Copy link
Contributor

maks commented Jul 14, 2017

@realitix I would suggest to use Github labels for marking issues as feature request, bugs, documentation, questions, etc. That then makes it easier to use the filtering functionality here.
Also because labels are something that only owner and contributors of a repo can set, this means it provides the opportunity for them to set a label as part of triaging incoming issues as I've found that works better than having users who open issues try to classify what an issue type is.

@realitix
Copy link
Contributor

@maks Of course I agree, but @gliechtenstein didn't give me the management role yet 😃
Maybe when Jasonette popularity will explode, @gliechtenstein will need dev to help him handle the load!

@maks
Copy link
Contributor

maks commented Jul 14, 2017

@realitix oh sorry! I didn't realise you didn't have access as I saw you marked as a contributor on the repo.
@gliechtenstein If you want helpers in future I'm also happy to put up my hand to help out.

@jxsp
Copy link

jxsp commented Jul 27, 2017

Interesting request, I can see how this would be useful. I will look into this coming weekend, I think this is doable. 👍

@maks
Copy link
Contributor

maks commented Jul 28, 2017

@jasperroest I've just done a PR (#149) for adding action/href for pin markers so you might want to base off of that or wait til its merged into develop.
If we are adding support for custom icons, we might as well also add support for other things that can be easily set via the Marker API:

  • color
  • opacity
  • rotation
  • z-index

@gliechtenstein I am assuming that you use Gmaps on iOS for the Map too and that these are all avialable there as well but please say if thats not so.

@jxsp
Copy link

jxsp commented Jul 28, 2017

@maks Ok that's great. I will wait a bit then, I can do a bit of preparation and research in the meantime, so that I know how to do it. I agree with your suggestion, adding those things as well makes sense.

@gliechtenstein
Copy link
Contributor

@maks on iOS we use Apple map because it's free and comes built-in by default with no API key necessary.

As for the additional attributes I think it's likely that they're doable but I can't say for certain at the moment since I'm not too familiar with customizing mapview on either ios or android. Will have to look into it.

@jxsp
Copy link

jxsp commented Jul 28, 2017

@gliechtenstein I am not an iOS developer, but perhaps I can look into Apple maps (it would be interesting to see how it compares to other map API's). But first I need to try to install OS X on my PC on Virtualbox, will try this weekend, after completing the this issue.

@gliechtenstein
Copy link
Contributor

@jasperroest that would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants