Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RebuildProjection<TView> shardTimeout ignored #2426

Closed
horego opened this issue Dec 11, 2022 · 1 comment · Fixed by #2425
Closed

RebuildProjection<TView> shardTimeout ignored #2426

horego opened this issue Dec 11, 2022 · 1 comment · Fixed by #2425
Labels
6.x async daemon bug projection rebuild
Milestone
6.0.0

Comments

@horego
Copy link

horego commented Dec 11, 2022

Hello everyone,

when calling RebuildProjection shardTimeout is not passed in the subroutine in the case of
typeof(TView).CanBeCastTo(typeof(ProjectionBase)) && typeof(TView).HasDefaultConstructor() and defaults always to 5.Minutes().

i created a pr for this issue.
#2425

thx. for your work.
best regards.
@jeremydmiller
Copy link
Member

Closed by #2425

@oskardudycz oskardudycz mentioned this issue May 5, 2023
Merged
@oskardudycz oskardudycz added this to the 6.0.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.x async daemon bug projection rebuild
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix RebuildProjection<TView> shardTimeout param passing horego/marten
3 participants
@jeremydmiller @oskardudycz @horego