Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception on postprocessUpdateAsync (Non async use side effect) #2428

Closed
horego opened this issue Dec 11, 2022 · 1 comment · Fixed by #2427
Closed

Exception on postprocessUpdateAsync (Non async use side effect) #2428

horego opened this issue Dec 11, 2022 · 1 comment · Fixed by #2427

Comments

@horego
Copy link

horego commented Dec 11, 2022

Hello everyone,

I have not digged to deep into the issue but i observe an error when rebuilding the projection. I ran into the issue where i got an exception from postprocessUpdateAsync while trying to execute
await reader.IsDBNullAsync(0, token).ConfigureAwait(false) after
!await reader.ReadAsync(token).ConfigureAwait(false)
since there is no data so IsDBNullAsync throw an exception. When compared to the non async method postprocessUpdate all is written in one line with conditional or operator ||. For me it looks like it should behave the same. What do you think?

i created a pr
#2427

btw. should i create a ticket and pr for the same issue? it feels redundant.

best regards

@horego horego changed the title Exception on postprocessUpdateAsync (Possible side effect) Exception on postprocessUpdateAsync (Non async use side effect) Dec 11, 2022
@jeremydmiller
Copy link
Member

Fixed by #2427

Thanks @horego!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants