Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new doc link and update existing ones #624

Closed
wants to merge 9 commits into from
Closed

Add new doc link and update existing ones #624

wants to merge 9 commits into from

Conversation

NiceSapien
Copy link
Contributor

added a new doc for admob interstitial ads and updated existing links. All the links of domain docs.sketchware.io replaced with sketchware-docs.vercel.app

@NiceSapien
Copy link
Contributor Author

didnt build, why:hels: closing till fixed

@NiceSapien NiceSapien closed this Oct 30, 2022
removed the lines which were messed up by git.
@PranavPurwar
Copy link
Contributor

i wonder how updating links can fail the build

@JavkhlanK
Copy link
Member

image

@NiceSapien
Copy link
Contributor Author

i wonder how updating links can fail the build

git messed up

@NiceSapien
Copy link
Contributor Author

image

yea, seen and fixed in my fork. should i open new pr?

@PranavPurwar
Copy link
Contributor

duplicate

@JavkhlanK
Copy link
Member

Next time, please use a new branch for your proposed changes, not main. That'll stop these weird inconsistencies.

@NiceSapien
Copy link
Contributor Author

NiceSapien commented Oct 30, 2022

duplicate

how do i update this existing pr:pensive:

@NiceSapien NiceSapien reopened this Oct 30, 2022
@JavkhlanK JavkhlanK added the fix This pull request contains a bugfix label Oct 30, 2022
@nicesapien-too
Copy link

Fix what😩

@NiceSapien
Copy link
Contributor Author

merge @JavkhlanK (you may remove those https://sketchware-docs.vercel.app urls if you'd like to coz i guess you dont trust it/me)

@JavkhlanK
Copy link
Member

using 'please' makes your request seem nicer btw

@JavkhlanK JavkhlanK closed this Nov 24, 2022
@NiceSapien
Copy link
Contributor Author

using 'please' makes your request seem nicer btw

dude

@NiceSapien
Copy link
Contributor Author

Hello @JavkhlanK . Please re-open this pr and merge it, else your mom.

@JavkhlanK
Copy link
Member

else your mom dn

@NiceSapien
Copy link
Contributor Author

bro pls merge now 😩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This pull request contains a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants