Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Go to moreblock #689

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TotallyNotMike
Copy link

this feature brings a fundamental problem to the table (discussed on discord) so I marked it as draft for now, at least till we figure out a reliable solution.

image

the icon I got from Flaticon does require attribution btw, like so:

<a href="https://www.flaticon.com/free-icons/export" title="export icons">Export icons created by Pixel perfect - Flaticon</a>

@hasrat-ali
Copy link
Member

I thought the edit icon would be in the block.

@hasrat-ali
Copy link
Member

Ohh, i didn't see the drafted pr

@hasrat-ali hasrat-ali added enhancement New feature or request feature A new feature labels Jan 1, 2023
@hasrat-ali
Copy link
Member

I think the edit icon should be a bit bigger.

@JavkhlanK JavkhlanK added has side-effect There's an unwanted side-effect and removed enhancement New feature or request labels Jan 3, 2023
@hasrat-ali hasrat-ali marked this pull request as ready for review January 3, 2023 11:45
@hasrat-ali
Copy link
Member

Oh, i accidently make it "ready for review"

@hasrat-ali
Copy link
Member

Btw, why it's labelled as has side-effect

@JavkhlanK JavkhlanK marked this pull request as draft January 3, 2023 11:58
@JavkhlanK
Copy link
Member

Because of that fundamental design problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature has side-effect There's an unwanted side-effect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants