Add ability to have the line start or end at any given point #116
Conversation
JBLineChartView uses numberOfVerticalValuesAtLineIndex to define the number of points, but subsequently requires that all chartPoints have a value anyway. This commit allows you to use NAN within the charts data.
|
Any update on this? This would be awesome to have |
|
@terryworona |
|
Sorry for not getting to this until now. It's a very good addition. I've made some comments and we need to address the crashes. As well, can you update the README with some information on NaN support? |
|
hi, thanks for the reply. i'll look into it later this week and fix your points, as well as update the README. |
|
Just wanted to say I've been testing this PR for a couple weeks and it's been working great for me. +1 on merging. |
|
Cool, just waiting on those last changes then it can be merged. I'll be away from computer for a few weeks, so take your time! |
|
Could really use this functionality as I'm looking for ways to hack around this right now while still using JBChartView |
|
Thanks for these fixes. Pulling it in! |
Add ability to have the line start or end at any given point
This pull requests adds the ability to have the line start or end at any given point.
Now lineChartView: verticalValueForHorizontalIndex: atLineIndex: can return NAN as a value and the line starts at the first non-nan value and ends at the last non-nan value.
i also added an example.