New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added area diagram functionality #42
Conversation
This would be a great addition. |
@terryworona Is there any particular reason, why this pull reequest hasn't been merged so far? I'm just wondering why it didn't happen until now. |
@hackingotter been meaning to look it over. This weekend! Promise! |
great. Thank you |
@@ -14,8 +14,8 @@ | |||
|
|||
@interface JBBarChartView : JBChartView | |||
|
|||
@property (nonatomic, weak) id<JBBarChartViewDelegate> delegate; | |||
@property (nonatomic, weak) id<JBBarChartViewDataSource> dataSource; | |||
@property (nonatomic, weak) IBOutlet id<JBBarChartViewDelegate> delegate; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these IBOutlets (forgive my naiveness, I never use IB); can the chart not be used with IB without these declared as outlets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the request. Generally looks good, but not quite ready for prime-time yet. There's a bunch of duplicate code that I think can be condensed. As well, I'd like to simply the interface for filling in lines. What do you think? |
I will try to remove the duplicate code. This will also improve the intergrationof future improvements. A simpler interface also would be nice. I'll use a delegate methode for the filling and for the filling color I will use the line color and lower the alpha so you still can seperate between line and the filling. About the stacked/cumulative lines I think that this feature should be left as it is, as I mentioned above. |
Ok, I changed a lot and condensed most of the duplicates but at one point there still is one (marked with FIXME) I don't know how to remove. For details loock at the comments I made. |
Yay! It's very cool feature! Thanks! |
@terryworona Could you please review the changes I made? |
Hey @hackingotter, thanks so much for the contribution and continued work on getting this polished. After a bit of discussion, we have decided to not pull in this particular feature, for a few reasons:
Your contributions are not at all lost and will be used going forward with our area graphs. You will be given contributor credit via the PR when the time comes. Thanks again! |
But a little improvement with IBOutlet is good feature to support storyboards: |
Hello
I like JBchartView, but I missed the possibility to fill the area under the lines to create a area diagram so I added it. I also added the area diagram to the sample.
I tried to follow the code style of the rest of the porject.