New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.9.5: Skein2 fails #194
Comments
I just tested and it works for me. Can you give more details? Did you try a different exe, different |
Thanks for your quick reply.
3.9.3.1 works fine:
There is not much useful debug information:
Other algos are OK (I have not tested them all)
other variants, e.g. cpuminer-Avx.exe just die the same. |
OK, maybe it's a Windows only problem. That usually means data misalignment. The debug data is still valuable because it helps localize the crash Thanks for your good reporting. |
Not much more here :-(
You're welcome. I am also willing to do some testing (if needed). |
I've fixed it by reverting the changes from v3.9.4 but I still don't know why it crashes, and only I was in the process of preparing another release with another bug fix and I'll include the skein2 I'm able to test at zpool but thanks for the offer. Still a lot of work to do. |
cpuminer-opt-3.9.5.1 is released, it should fix the skein crash. You can close this issue if your I've opened a follow up issue to find the root cause. |
Skein2 is working in 3.9.5.1 |
Reopening to investigate further. This appears to be a skein specific issue. The crash does not occur in the code that triggered it. If the problem is pointer alignment it's not the pointer I suspected (pdata) as it is confirmed correctly |
It wasn't pointer alignment, it was a buffer overflow. The bswap-interleave optimization was only a Final hash is 32 bytes for all algos but many algos have The bswap-interleave optimization eliminated the need for a temporary copy of the input data It's fixed in v3.9.5.4. |
Miner just closes.
The text was updated successfully, but these errors were encountered: