Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.12.1: Xevan AVX2 broken #238

Closed
JayDDee opened this issue Feb 8, 2020 · 6 comments
Closed

v3.12.1: Xevan AVX2 broken #238

JayDDee opened this issue Feb 8, 2020 · 6 comments
Labels
bug fix released regression

Comments

@JayDDee
Copy link
Owner

JayDDee commented Feb 8, 2020 •
edited

Xevan avx2 produces all invalid shares. Discovered in v3.12.2-dev, last working version v3.11.7.
@JayDDee JayDDee changed the title Xevan AVX2 broken v3.12.2: Xevan AVX2 broken Feb 8, 2020
@JayDDee JayDDee changed the title v3.12.2: Xevan AVX2 broken v3.12.1: Xevan AVX2 broken Feb 8, 2020
@JayDDee
Copy link
Owner Author

JayDDee commented Feb 8, 2020 •
edited

The problem has been isolated to a change in skein-hash-4way.c to support midstate
pre-hashing. It apparently broke xevan with its 128 bit data size.

@JayDDee
Copy link
Owner Author

JayDDee commented Feb 9, 2020 •
edited

Skein & skein2 AVX2 also broken, same problem, same fix.

@JayDDee JayDDee mentioned this issue Feb 9, 2020
Closed
@JayDDee
Copy link
Owner Author

JayDDee commented Feb 9, 2020

cpuminer-opt-3.12.2 is released.

@JayDDee
Copy link
Owner Author

JayDDee commented Feb 9, 2020

User also reported skunk was broken but was overlooked. It will be in the next release.

It also use skein as the first function and will be a beneficiary of midstate optimization once
#239 is solved.

@JayDDee
Copy link
Owner Author

JayDDee commented Feb 9, 2020

I've applied the fix to skunk but testing is near impossible because difficulty is so high.
It doesn't segfault anymore.

@JayDDee
Copy link
Owner Author

JayDDee commented Feb 10, 2020

Did a test of skunk AVX2 for #239 and was able to get a good share.
I'm still not sure about v3.12.2, but it's moot now because it works in 3.12.3.
It's also faster.

Closing.

@JayDDee JayDDee closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fix released regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JayDDee