Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch Make Long Shadow plugin doesn't work #4

Open
nshelmuk opened this issue Aug 18, 2016 · 23 comments
Open

Sketch Make Long Shadow plugin doesn't work #4

nshelmuk opened this issue Aug 18, 2016 · 23 comments
Assignees

Comments

@nshelmuk
Copy link

Sketch version 39.1 (31720)

@JayHoltslander
Copy link
Owner

@abynim Do you have time to look into this?

@lundzern
Copy link

lundzern commented Sep 2, 2016

i can confirm this issue.

@arnoesterhuizen
Copy link

arnoesterhuizen commented Sep 30, 2016

One thing I noticed is that the plugin requires "common.js", and that isn't copied over by default when the plugin is installed. When I copy common.js into the plugin folder manually, I get the dialog, but the action still doesn't apply.

Version 40.1 (33804)

@martinbackes
Copy link

hey there, is there going to be update version soon for Sketch 40....
Thanks :)

@abynim
Copy link
Collaborator

abynim commented Oct 23, 2016

@JayHoltslander do you want to add me as a collaborator on this repo? I have the changes made already, just need permission to commit :)

@lapidus
Copy link

lapidus commented Oct 25, 2016

+1

@lundzern
Copy link

+1

Get Outlook for iOS

On Tue, Oct 25, 2016 at 3:04 PM +0200, "lapidus" notifications@github.com wrote:

+1


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@knappdaddy
Copy link

@abynim - i'm still having issues. did you merge?

@WinayakBongarge
Copy link

Not working on Sketch 41, Dialogue opens but its not adding shadow

@joshuamanns
Copy link

@abynim do you have a repo or branch with the updates I can use? Would be convenient!

@abynim
Copy link
Collaborator

abynim commented Jan 16, 2017

Pushed a fix for Sketch 40 and above. Please test!

@martinbackes
Copy link

Hey, it works for me with Sketch Version 41.2 (35397), its just that Sketch still puts it into the "Legacy Plugins" folder. So as far as I know, Sketch thinks its outdated, right? Any idea why this is happening and how to fix this?

@joshuamanns
Copy link

@abynim thank you! It works well - I can confirm the legacy folder placement as well but that just has to do with how it was packaged up. Thanks again

@abynim
Copy link
Collaborator

abynim commented Jan 18, 2017

Pushed another update with a fix for the legacy folder placement. Also added Sketch Runner integration.
long-shadow

@DarinJi
Copy link

DarinJi commented Apr 13, 2017

not working on sketch43

@ZillieZephyr
Copy link

Are there any plans to update this? I usually use OPO for illustrator to do this, but it is also broken at the moment.

@Shyri
Copy link
Contributor

Shyri commented Jun 12, 2017

Just made a pull request in order to make it work for Sketch 44.1
#8

@joakimmelkersson-ld
Copy link

Not working in latest Sketch (45.2). Nothing happens when trying it. Any plans on fixing it?

@JayHoltslander
Copy link
Owner

Try now?

@eledroos
Copy link

Not working with Sketch 46.2 @JayHoltslander

@thepixelparent
Copy link

@JayHoltslander I can confirm as well this is still not working for Sketch 46.2. I was on 46.1 and was not working, just upgraded and still no working.

@sbible
Copy link

sbible commented Oct 25, 2017

Also not working in Sketch 47.1. Dialog with options loads, but clicking "Make Shadow" doesn't do anything.

@sqott-zz
Copy link

^ same on 49.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests