Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate compose compiler metrics and fix any issues present #101

Closed
3 tasks done
jayasuryat opened this issue May 18, 2022 · 4 comments
Closed
3 tasks done

Generate compose compiler metrics and fix any issues present #101

jayasuryat opened this issue May 18, 2022 · 4 comments
Assignees
@jayasuryat
Labels
code quality refactor
Milestone
v1.0.0

Comments

@jayasuryat
Copy link
Owner

jayasuryat commented May 18, 2022 •
edited

Compose compile metrics

Finally there is a good tool to give some information about how composables might be performing.

  • Setup gradle configuration to enable compose compiler metrics
  • Generate metrics
  • Check and fix if any issue(s) found
@jayasuryat jayasuryat self-assigned this May 18, 2022
jayasuryat added a commit that referenced this issue May 18, 2022
@jayasuryat
Setup gradle configuration for enabling compose-compiler-metrics (#101
987043e 
)
@jayasuryat
Copy link
Owner Author

So far these are the composables which are restartable but not skippable.
Need to check and fix these composables on case by case basis.

Screenshot 2022-05-19 at 12 01 44 AM

merged_release-composables.csv

How to interpret these metrics?
Read here

@jayasuryat
Copy link
Owner Author

jayasuryat commented May 22, 2022 •
edited

Issues found :

❌ GameScreen
❌ SettingsScreen

jayasuryat added a commit that referenced this issue May 22, 2022
@jayasuryat
Mark MusicManager and VibrationManager as stable (#101)
b07d888
jayasuryat referenced this issue May 22, 2022
@jayasuryat
Wrap Painter param of FlagIcon composable with ImmutableHolder
467ac7d
jayasuryat added a commit that referenced this issue May 22, 2022
@jayasuryat
Wrap dificultyLevels param of LevelPager composable with `Immutab…
10b109f 
…leHolder` (#101)
@jayasuryat
Copy link
Owner Author

All issues found have been fixed apart from the screens.

Screens have been left as-is as they have a viewmodel as param, and I need more time read and understand if those classes can be marked as @Stable

@jayasuryat
Copy link
Owner Author

compose-compiler-fixes-1

merged_release-composables_fix_1.csv

@jayasuryat jayasuryat added this to the v1.0.0 milestone Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayasuryat jayasuryat

Labels
code quality refactor
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@jayasuryat