Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package names inconsistent between requirements and installed packages #55

Open
JeanChristopheMorinPerso opened this issue Oct 14, 2023 · 1 comment · May be fixed by #57
Open

Package names inconsistent between requirements and installed packages #55

JeanChristopheMorinPerso opened this issue Oct 14, 2023 · 1 comment · May be fixed by #57
Labels
bug Something isn't working

Comments

@JeanChristopheMorinPerso
Copy link
Owner

JeanChristopheMorinPerso commented Oct 14, 2023

See AcademySoftwareFoundation/rez#1545.

Basically, there is an inconsistency between the packages we install, and the packages that we put in the requirements. On top of the issue reported in the linked issue, the new rez-pip also has problems with uppercased vs lowercased packages.

Package name canonization is annoying... https://blog.piwheels.org/canonicalise-all-the-things/.

We can fix this issue by changing

return name.replace("-", "_")
to always lower-case the name and also replace . with _.

To confirm that it really works, we can run REZ_PACKAGES_PATH=~/rez_packages rez-pip2 prefect==2.13.6 -p /tmp/asd --python-version 3.9 -- -v and then rez-env prefect and it should work.

We might want to also print a report at the end with a mapping between the original names and the new names if it's possible to do. We might also want to harmonize the names across the logs.

@MrLixm
Copy link
Contributor

MrLixm commented Jan 12, 2024

Hello ! I think I just ran in the issue when trying to install sphinx==7.2.6.

$ rez env sphinx furo
12:40:45 ERROR    PackageFamilyNotFoundError: package family not found: sphinx (searched: C:\Users\lcoll\rez\packages; N:\packages; Z:\rez\packages)
$ rez env Sphinx furo
12:40:56 ERROR    PackageFamilyNotFoundError: package family not found: babel, was required by: Sphinx (searched: C:\Users\lcoll\rez\packages; N:\packages; Z:\rez\packages)

Is the corresponding PR for that issue considered done ? Or any help needed to get it merge ?
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants