Upgrade to 7.6.1 is not possible with core value converters installed

[dawoe]

If you installed this package through on a pre v7.6 site and want to upgrade to 7.6.1 this is not possible.

The nuget package depedency to Umbraco core is restricted to 7.6.0 or lower

[Jeavon]

It's intentional but should have been < 7.6.0 though, my mistake. This package should be removed before upgrading to Umbraco v7.6 as it's not needed due to having been merged into core

[dawoe]

I sort of disagree. On upgrades the value converters in 7.6 are disabled.
So the this package should keep working in that case.

Also upgrading now to 7.6.1 is not easy when you have this package installed. You first need to remove it. In case you are using Models builder your site will be broken at that point. Then you can do the upgrade and have to explicit enable it in config. Rebuilding your models now can cause issues. Some valueconverters have been added and return different objects than pre 7.6.

Not easy in my opinion, and not clear to every one.

Dave

[Jeavon]

I need to update the readme on this package to explain that it should be removed and the setting enabled when upgrading for sure. Yes the RelatedLinks model has of changed namespace so Models Builder will need to rerun if you are using the API.

Technically this package could continue as these value converters would override the Core ones. But I don't think it makes sense to continue to maintain this package now though since it's merged so it's important upgraders switch to using the Core version don't you think?

The only reason why someone might "need" this package if for the dynamics support which is not in Umbraco Core but nobody has asked yet :)

[dawoe]

Hi Jeavon,

I created this issue because of this post : https://our.umbraco.org/forum/using-umbraco-and-getting-started/85625-banging-on-about-upgradesagain#comment-271224

I see, and you probably as well, a lot of questions regarding this on the forum. And about the new UDI format. I think HQ should communicate these kind of "breaking" changes better.

Dave

[Jeavon]

@dawoe I'm really interested if you think it's correct to cease maintaining this package, of course it currently doesn't support the UDI pickers although I could add them or if it's right to "force" people to convert to using the Core versions?

FYI I have updated the Readme with instructions on upgrades. https://github.com/Jeavon/Umbraco-Core-Property-Value-Converters#upgrading-to-umbraco-76

[dawoe]

Hi Jeavon,

I have read the docs...but how many people should actually do ?
You should not maintain this package. But also should not prevent upgrades.
Actually don't know how to solve this. I think maybe a blog from HQ can solve a lot of issues.

Dave

[schrepel]

We just upgraded from 7.5.13 to 7.6.1 which broke non-strongly-typed code that had been relying on the PropertyConverters package (see my note at issues.umbraco). Since we had already completed the upgrade before discovering the "remove this package first" note, I was concerned that I'd have to re-write it all as strongly-typed (which I'm not as familiar with).

But setting EnablePropertyValueConverters to false in umbracoSettings.config seems to have corrected things (code's running as it did before).

[Jeavon]

I have come across some other reasons to allow this package to be used with v7.6 so I have removed the restriction from v3.1.3 now available from NuGet. I have also tested with a upgrade and there are no issues except for potential confusion with the duplicate RelatedLinks models