Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant customize button classes #9

Closed
luisrudge opened this issue Jun 8, 2015 · 7 comments
Closed

cant customize button classes #9

luisrudge opened this issue Jun 8, 2015 · 7 comments
Assignees

Comments

@luisrudge
Copy link

No description provided.

@jossmac
Copy link
Collaborator

jossmac commented Jun 8, 2015

Hi @luisrudge,

The buttons use very specific classes so they don't conflict with any existing button styles.

Perhaps the buttons should use predefined variables that can be easily updated?

@jossmac jossmac self-assigned this Jun 8, 2015
@luisrudge
Copy link
Author

maybe it should receive via props

@jossmac
Copy link
Collaborator

jossmac commented Jun 9, 2015

I just can't see it being helpful, remembering of course that the buttons have two different states when in a single calendar VS multi-picker.

Could you explain a use case for this?

@luisrudge
Copy link
Author

the use case is when you're using bootstrap, for example and you want to add a specific set of classes

@jossmac
Copy link
Collaborator

jossmac commented Jun 9, 2015

If you take a look at the single date picker and the multi date picker side-by-side you'll notice that the footer buttons are very different

Applying bootstrap classes, for instance btn btn-primary, would only work for the multi picker - making the single picker footer buttons break.

I think a more prudent solution might be to write a small bit of CSS, leveraging LESS's ability to use classes as mixins:

.multi-picker .DateSelectFooter__button--primary {
  .btn();
  .btn-primary();
}

@luisrudge
Copy link
Author

I'm talking about this button. Not the buttons inside the picker itself

@jossmac
Copy link
Collaborator

jossmac commented Jun 9, 2015

Oh right!

The trigger element will be completely arbitrary with the updates @dcousens is making in the refacto branch.

Sorry for the confusion, closing


Important:

When you're creating issues in the future please use specific issue names, and write a detailed description.

@jossmac jossmac closed this as completed Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants