-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme support #109
Comments
@jossmac you might have a better handle on this could be done. |
👍 |
I'm interested by the theme support. Is a PR in progress about this ? |
@JedWatson might be time to convert to Radium, thoughts? |
@jossmac any news about this ? |
@piecyk depending on the result of some research for a commercial project, it's likely that we'll re-implement using styled-components |
@jossmac if you re-implement using styled-components, will the reimplementation include a Specifically, I'd like to be able to do something like... // my-select-one.scss
$select-input-height: 50px;
$select-input-border-radius: 0;
$select-item-font-size: 16px;
$select-padding-vertical: 17px;
$select-padding-horizontal: 18px;
@import "../node_modules/react-select/scss/default";
// my-select-two.scss
$select-input-height: 25px;
$select-input-border-radius: 2;
// ...
@import "../node_modules/react-select/scss/default"; And then, using |
@petejodo I'd like to provide more granular control of the component styles. Though the best pattern I've discovered so far uses Glamor by itself. Theme CSS Renderers I'll keep exploring different options. |
cool. I haven't heard of Glamor before. I actually completely forgot about the optional renderers. I should be able to just create my own with my own styles to get my desired result then |
v2 has a complete styling API now 👍 |
For better override styles (when you need to have 3 components whit different look) created something like props.theme, ref to gist
https://gist.github.com/piecyk/14cfd932aabd1989ff10
and usage
i want to created a pull request with this, but maybe is there a better solution... any thoughts?
The text was updated successfully, but these errors were encountered: