Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fix for #2716 - Missing type annotation for U. #2732

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

himerus
Copy link
Contributor

@himerus himerus commented Jun 20, 2018

Fix for #2716 thanks to @Erkan1991 (fix).

screenshot of atom 6-20-18 9-45-54 am

@himerus himerus changed the title Fix for #2616 - Missing type annotation for U. [v2] Fix for #2616 - Missing type annotation for U. Jun 20, 2018
@himerus
Copy link
Contributor Author

himerus commented Jun 20, 2018

Darn, the commit message has the wrong issue number. Let me know (ping) if I should resubmit.

@himerus himerus changed the title [v2] Fix for #2616 - Missing type annotation for U. [v2] Fix for #2716 - Missing type annotation for U. Jun 20, 2018
@gwyneplaine
Copy link
Collaborator

@himerus thanks for this, looks good to me, if you could update the commit with the correct issue number, i'll merge it in 👍

@himerus
Copy link
Contributor Author

himerus commented Jun 21, 2018

@gwyneplaine Should be GTG now. Thanks!

@gwyneplaine gwyneplaine merged commit 30dee63 into JedWatson:v2 Jun 21, 2018
@gwyneplaine
Copy link
Collaborator

merged, thanks @himerus

@erksdee
Copy link

erksdee commented Jun 21, 2018

Hey @gwyneplaine, is there a ETA for the next release that includes this fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants