Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] fix className composition #2733

Merged
merged 1 commit into from
Jun 27, 2018
Merged

[v2] fix className composition #2733

merged 1 commit into from
Jun 27, 2018

Conversation

nihgwu
Copy link
Contributor

@nihgwu nihgwu commented Jun 20, 2018

right now if isDisabled={true} the container's className would be prefix__--is-disabled

@SilencerWeb
Copy link

but it should be prefix__name--is-disabled if name is passed and prefix--is-disabled if name isn't passed

@nihgwu
Copy link
Contributor Author

nihgwu commented Jun 22, 2018

the problem is when name='--is-disabled' it becomes prefix__--is-disabled

@nihgwu nihgwu mentioned this pull request Jun 23, 2018
Closed
@JedWatson
Copy link
Owner

Good catch @nihgwu, thanks!

@JedWatson JedWatson merged commit 7409317 into JedWatson:v2 Jun 27, 2018
@nihgwu nihgwu deleted the neo/className branch June 27, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nihgwu @SilencerWeb @JedWatson