Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/react interferes with preact types #4962

Open
weedz opened this issue Dec 18, 2021 · 0 comments
Open

@types/react interferes with preact types #4962

weedz opened this issue Dec 18, 2021 · 0 comments
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@weedz
Copy link

weedz commented Dec 18, 2021

I noticed this package uses @types/react-transition-group as a regular dependency which in turn depends on @types/react. @types/react interferes with the JSX types from preact so we get warnings like:

'MenuLink' cannot be used as a JSX component.
  Its instance type 'Component<IMenuLink, {}>' is not a valid JSX element.ts(2786)

Are there any problems with moving @types/react-transition-group into devDependencies? This seems to fix our issue.

@weedz weedz added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

No branches or pull requests

1 participant