Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMounted is deprecated #105

Closed
dcousens opened this issue May 8, 2017 · 1 comment

Comments

@dcousens
Copy link
Collaborator

commented May 8, 2017

Warning: Tappable: isMounted is deprecated. Instead, make sure to clean up subscriptions and pending requests in componentWillUnmount to prevent memory leaks.

@dcousens dcousens added the bug label May 8, 2017

@dcousens dcousens added the task label Jun 16, 2017

@dcousens dcousens changed the title Warning: Tappable: isMounted is deprecated isMounted is deprecated Jun 16, 2017

matthieuprat added a commit to matthieuprat/react-tappable that referenced this issue Jul 3, 2017
matthieuprat added a commit to matthieuprat/react-tappable that referenced this issue Jul 3, 2017
Fix `isMounted` deprecation
As of React 15.5, `isMounted` is deprecated.

This changeset is based on React's own `isMounted` implementation:
https://github.com/facebook/react/blob/v15.6.1/addons/create-react-class/factory.js#L695-L705

Fixes JedWatson#105.
@dcousens

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 10, 2017

Closing in favour of #111

@dcousens dcousens closed this Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.