Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo: Add warning or update npm node version requirements for node >10 && < 10.4.0 #26

Open
Jeff-Lewis opened this issue Aug 3, 2018 · 2 comments
Open

Todo: Add warning or update npm node version requirements for node >10 && < 10.4.0 #26

Jeff-Lewis opened this issue Aug 3, 2018 · 2 comments
Assignees
@Jeff-Lewis
Labels
enhancement

Comments

@Jeff-Lewis
Copy link
Owner

See #24
@Jeff-Lewis Jeff-Lewis self-assigned this Aug 3, 2018
@Jeff-Lewis Jeff-Lewis changed the title Todo: Add warning or update npm node version requirements for node >10 && < 10.4,0 Todo: Add warning or update npm node version requirements for node >10 && < 10.4.0 Aug 3, 2018
@bmacnaughton
Copy link

Is the reason for this that node versions > 10 && < 10.4.0 broke async_hooks?

References:
nodejs/node#20516
nodejs/node#20274

So it's node >= 10.0.0 && < 10.4.0?

@kmetsalu
Copy link

Im I right to understand that this means that cls-hooked does not work with 10.5.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeff-Lewis Jeff-Lewis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jeff-Lewis @kmetsalu @bmacnaughton